Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify debugger.sendCommand() (backport: 5-0-x) #16931

Merged
merged 1 commit into from Feb 13, 2019
Merged

feat: promisify debugger.sendCommand() (backport: 5-0-x) #16931

merged 1 commit into from Feb 13, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 13, 2019

Backport of #16861

See that PR for details.

Notes: Converted debugger.sendCommand() to return a Promise instead of taking a callback.

@trop trop bot requested review from a team February 13, 2019 17:54
@trop trop bot mentioned this pull request Feb 13, 2019
Merged
6 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Feb 13, 2019
@jkleinsc jkleinsc merged commit b4bd96b into electron:5-0-x Feb 13, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 13, 2019

Release Notes Persisted

Converted debugger.sendCommand() to return a Promise instead of taking a callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @miniak